Skip to content

feat: ios16 support#2469

Merged
juliusmarminge merged 2 commits intot3code/mobile-remote-connectfrom
yash/ios16-mobile
May 4, 2026
Merged

feat: ios16 support#2469
juliusmarminge merged 2 commits intot3code/mobile-remote-connectfrom
yash/ios16-mobile

Conversation

@Yash-Singh1
Copy link
Copy Markdown
Collaborator

@Yash-Singh1 Yash-Singh1 commented May 2, 2026

What Changed

Adds ios 16 support to the GhosttyKit library used in mobile app

Why

So we support ios 16

Checklist

  • This PR is small and focused
  • I explained what changed and why

Note

Medium Risk
Updates the vendored native GhosttyKit.xcframework and its C API surface, which can affect terminal rendering/input behavior on iOS at runtime. Risk is mitigated by minimal Swift-side changes (signature alignment) and added rebuild documentation/script for repeatability.

Overview
Adds iOS 16 support for the mobile terminal by updating the vendored GhosttyKit.xcframework to a new custom-I/O fork/revision and refreshing the shipped headers (ghostty.h) and Vendor/libghostty/VERSION.

Aligns T3TerminalView.swift with the updated Ghostty runtime callback signature (read_clipboard_cb now returns bool) and documents/reprovisions the vendor build via a new scripts/build-libghostty-ios16.sh plus README/third-party notice updates.

Separately pins shiki to 3.23.0 in apps/mobile/package.json (and lockfile) to avoid dependency conflicts with packages expecting different shiki major versions.

Reviewed by Cursor Bugbot for commit 40cc9c5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add iOS 16 support to the mobile terminal using a custom Ghostty fork

  • Updates vendored GhosttyKit.xcframework to a custom-I/O fork of Ghostty with an iOS 16 compatibility patch (revision d36c3b8).
  • Adds build-libghostty-ios16.sh, a script to rebuild the xcframework from source using Zig 0.15.2, replacing only the ios-arm64 and ios-arm64-simulator slices.
  • Updates T3TerminalView.swift to return false from the read_clipboard_cb closure to match the updated ghostty_runtime_read_clipboard_cb signature (changed from void to bool).
  • Adds shiki@3.23.0 as a dependency and updates the lockfile with scoped resolutions to avoid conflicts with packages expecting shiki@4.x.

Macroscope summarized 40cc9c5.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d403649f-1ff3-4347-b16d-cf50a01f4a40

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yash/ios16-mobile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels May 2, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 2, 2026

Approvability

Verdict: Needs human review

This PR updates a vendored native iOS library (GhosttyKit) with iOS 16 compatibility patches. Vendored binary updates cannot be fully verified through code review alone, and this enables new platform support, warranting human review.

No code changes detected at 40cc9c5. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge force-pushed the t3code/mobile-remote-connect branch from 842c2d5 to 96897ab Compare May 4, 2026 03:15
@juliusmarminge juliusmarminge merged commit 057d3f2 into t3code/mobile-remote-connect May 4, 2026
13 checks passed
@juliusmarminge juliusmarminge deleted the yash/ios16-mobile branch May 4, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants